New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing remote object error when calling remote function created in preload script (4-0-x) #15446

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Oct 29, 2018

Backport #15444 to 4-0-x.

Notes: Fix missing remote object error when calling remote function created in preload script

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Oct 29, 2018

@zcbenz zcbenz merged commit d07115e into 4-0-x Oct 31, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be merged or rebased
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 31, 2018

Release Notes Persisted

Fix missing remote object error when calling remote function created in preload script

@zcbenz zcbenz deleted the fix-missing-object-4-0-x branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment