New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify menu item properties not available top-level (backport: 3-0-x) #15461

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
1 participant
@trop
Contributor

trop bot commented Oct 29, 2018

Backport of #15458

See that PR for details.

Notes: update docs to reflect top-level menu item property issues

@trop trop bot requested a review from electron/docs as a code owner Oct 29, 2018

@trop trop bot referenced this pull request Oct 29, 2018

Merged

docs: clarify menu item properties not available top-level #15458

4 of 4 tasks complete

@trop trop bot added 3-0-x backport labels Oct 29, 2018

@codebytere codebytere merged commit fd97fcf into electron:3-0-x Oct 29, 2018

11 of 14 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
ci/circleci: electron-linux-ia32 Your tests failed on CircleCI
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 29, 2018

Release Notes Persisted

update docs to reflect top-level menu item property issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment