New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set `windowsHide` to the old node default #15469

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Member

MarshallOfSound commented Oct 30, 2018

Fixes #15467

Notes: fix Electron not being visible when launching in development mode on node v11

@MarshallOfSound MarshallOfSound requested a review from electron/electrocats as a code owner Oct 30, 2018

@MarshallOfSound MarshallOfSound referenced this pull request Oct 30, 2018

Closed

fix: electron could not open on node 11 #15470

3 of 3 tasks complete

@MarshallOfSound MarshallOfSound merged commit e9fab74 into master Oct 31, 2018

19 of 20 checks passed

ci/circleci: linux-ia32-testing Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 31, 2018

Release Notes Persisted

fix Electron not being visible when launching in development mode on node v11

@MarshallOfSound MarshallOfSound deleted the MarshallOfSound-patch-3 branch Oct 31, 2018

@trop

This comment has been minimized.

Contributor

trop bot commented Oct 31, 2018

I was unable to backport this PR to "1-8-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Contributor

trop bot commented Oct 31, 2018

I was unable to backport this PR to "3-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Contributor

trop bot commented Oct 31, 2018

I was unable to backport this PR to "2-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Contributor

trop bot commented Oct 31, 2018

We have automatically backported this PR to "4-0-x", please check out #15511

@trop trop bot added merged/4-0-x and removed target/4-0-x labels Oct 31, 2018

@refack

This comment has been minimized.

refack commented Nov 1, 2018

So what is the scope of affect the change in default has on Electron use cases?
Is it even beneficial to Electron?

AFAICT the more annoying issue of the flashing console even when windowsHide is set to true was actually fixed in:
libuv/libuv#1558
and
libuv/libuv#1659

@refack

This comment has been minimized.

refack commented Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment