Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove hardcoded google api key #15478

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented Oct 30, 2018

Description of Change

Remove hardcoded Google API key as current pricing tiers and requirements have precluded it from working in a free capacity for quite some time. Update documentation to reflect that it must now exclusively be passed in via env var.

/cc @zcbenz

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: remove hardcoded Google API key

@codebytere codebytere requested review from as code owners Oct 30, 2018

@codebytere codebytere changed the title refactor: remove google api key refactor: remove hardcoded google api key Oct 30, 2018

@ckerr
Copy link
Member

left a comment

Was the GOOGLEAPIS_ENDPOINT definition from he removed header not used anywhere?

webservice. Because this API key is included in every version of Electron, it
often exceeds its usage quota. To work around this, you can supply your own
Google API key in the environment. Place the following code in your main process
You can supply your own Google API key in the environment. Place the following code in your main process

This comment has been minimized.

Copy link
@ckerr

ckerr Oct 30, 2018

Member

This loses the context that the previous revision had of "what is this key for."

Maybe something like

You can provide an API key for making requests to Google's geocoding webservice. To do this, place the following code in your main process

@deepak1556

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

@ckerr GOOGLEAPIS_ENDPOINT was required to be provided alongside the api key to form the request url, long time back. In the recent implementations, it is only required to provide the api key and the endpoint is hardcoded in chromium https://cs.chromium.org/chromium/src/services/device/geolocation/network_location_request.cc?l=216. So it can be removed safely.

@ckerr

ckerr approved these changes Oct 31, 2018

@jkleinsc
Copy link
Contributor

left a comment

LGTM

@codebytere codebytere merged commit b2e1a93 into master Oct 31, 2018

25 of 26 checks passed

electron-osx-testing Build #20181031.14 has failed
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181031.1 succeeded
Details
electron-arm64-testing Build #20181031.1 succeeded
Details
electron-lint Build #20181031.6 succeeded
Details
electron-mas-testing Build #20181031.6 succeeded
Details
release-notes Release notes found

@codebytere codebytere deleted the remove-google-api-key branch Oct 31, 2018

@release-clerk

This comment has been minimized.

Copy link

commented Oct 31, 2018

Release Notes Persisted

remove hardcoded Google API key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.