Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect high contrast color mode #15493

Merged
merged 3 commits into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@brenca
Copy link
Member

commented Oct 31, 2018

Description of Change

Implements #13178's request. The gist of the issue is already well described there, but a tldr:
We currently can detect inverted color schemes (light text, dark background), and those are a subset of high contrast color schemes, but we can't detect the rest of the high contrast schemes. With this new method and event, this is resolved.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: added event and method to detect high contrast color schemes

@brenca brenca requested a review from MarshallOfSound Oct 31, 2018

@brenca brenca requested review from as code owners Oct 31, 2018

@ckerr

ckerr approved these changes Oct 31, 2018

@jkleinsc
Copy link
Contributor

left a comment

LGTM

@jkleinsc jkleinsc merged commit 6d2a088 into master Oct 31, 2018

25 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181031.4 succeeded
Details
electron-arm64-testing Build #20181031.4 succeeded
Details
electron-lint Build #20181031.4 succeeded
Details
electron-mas-testing Build #20181031.4 succeeded
Details
electron-osx-testing Build #20181031.4 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 31, 2018

Release Notes Persisted

added event and method to detect high contrast color schemes

@jkleinsc jkleinsc deleted the brenca/high-contrast branch Oct 31, 2018

@Logerfo

This comment has been minimized.

Copy link

commented Jan 10, 2019

What if the user has a custom theme installed in windows? A theme which changes the system colors to make a dark theme. Example: penumbra. There will be no indicator to the application building in an electron framework. Would it be possible for electron to expose the Windows system colors (if the running OS is Windows, of course)? If this is already available, I couldn't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.