Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly display zoom in accelerator on mac #15502

Merged
merged 3 commits into from Nov 7, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented Oct 31, 2018

Description of Change

Resolves #15496.

Backports this CL from Chromium to fix Cmd+Plus to zoom keyboard shortcut. Tested to fix the display, but there is some weirdness around still needing Shift to trigger the correct zoom behavior.

Ideally, i think we should enable both Cmd+Plus and Shift+Cmd+Plus to zoom on MacOS, as this most closely mirrors corresponding behavior on Chrome itself.

/cc @brenca @alexeykuzmin @MarshallOfSound

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: fix incorrect display of 'zoom in' accelerator on mac

@codebytere codebytere requested a review from as a code owner Oct 31, 2018

@codebytere codebytere changed the title fix: correctly display zoom in accelerator on mac [WIP] fix: correctly display zoom in accelerator on mac Oct 31, 2018

@brenca

brenca approved these changes Oct 31, 2018

Copy link
Member

left a comment

👍

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

Tested to fix the display, but there is some weirdness around still needing Shift to trigger the correct zoom behavior.

This is sad =/

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@alexeykuzmin yeah that's why i marked it WIP sadly

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

@codebytere Let's merge this PR since it fixes the menu issue,
And create a new PR for the shortcut issue.

@codebytere codebytere changed the title [WIP] fix: correctly display zoom in accelerator on mac fix: correctly display zoom in accelerator on mac Nov 7, 2018

@codebytere codebytere merged commit 833269f into master Nov 7, 2018

23 of 24 checks passed

Backportable? - 4-0-x Backport Failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181107.21 succeeded
Details
electron-arm64-testing Build #20181107.21 succeeded
Details
electron-lint Build #20181107.28 succeeded
Details
electron-mas-testing Build #20181107.30 succeeded
Details
electron-osx-testing Build #20181107.33 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 7, 2018

Release Notes Persisted

fix incorrect display of 'zoom in' accelerator on mac

@trop

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@ckerr ckerr deleted the fix-zoom-in-mac branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.