Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add v8_context_generator to mksnapshot zip (3-0-x) #15505

Merged
merged 2 commits into from Nov 5, 2018

Conversation

2 participants
@jkleinsc
Copy link
Contributor

jkleinsc commented Oct 31, 2018

Starting with 3-0-x, in order to use custom snapshots the v8_context_snapshot_generator binary is also needed. This PR adds the needed files to our dist files used for release.
This PR also add tests for mksnapshot.

Description of Change

Checklist

Release Notes

Notes: Added v8_context_generator binary to mksnapshot zip

@jkleinsc jkleinsc requested a review from as a code owner Oct 31, 2018

@jkleinsc jkleinsc changed the title build: add v8_context_generator to mksnapshot zip build: add v8_context_generator to mksnapshot zip (3-0-x) Oct 31, 2018

build: add v8_context_generator to mksnapshot
Starting with 3-0-x, in order to use custom snapshots the v8_context_snapshot_generator binary is also needed.
Also, add tests for mksnapshot.

@jkleinsc jkleinsc force-pushed the add-v8-context-gen branch from 256b1e3 to 0c103bb Nov 5, 2018

Show resolved Hide resolved .circleci/config.yml Outdated
@jkleinsc

This comment has been minimized.

Copy link
Contributor Author

jkleinsc commented Nov 5, 2018

Merging as CI flakes are not related to these changes.

@jkleinsc jkleinsc merged commit ec6fe27 into 3-0-x Nov 5, 2018

15 of 18 checks passed

ci/circleci: electron-linux-ia32 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 5, 2018

Release Notes Persisted

Added v8_context_generator binary to mksnapshot zip

@jkleinsc jkleinsc deleted the add-v8-context-gen branch Nov 5, 2018

@sofianguy sofianguy added this to Fixed (3.0.8) in 3.0.x / 3.1.x Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.