New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor properties.showHiddenFiles on Linux (backport: 4-0-x) #15506

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Oct 31, 2018

Backport of #15503

See that PR for details.

Notes: Honor properties.showHiddenFiles in dialog.showOpenDialog() on Linux

fix: honor properties.showHiddenFiles on Linux
Previously the code only set the GtkFileChooser's property if
`properties.showHiddenFiles` was set. This PR unconditionally
sets the GtkFileChooser's property so that hidden files will be
hidden if `properties.showHiddenFiles` was not set.

@trop trop bot requested a review from electron/reviewers as a code owner Oct 31, 2018

@trop trop bot referenced this pull request Oct 31, 2018

Merged

fix: honor properties.showHiddenFiles on Linux #15503

3 of 3 tasks complete

@trop trop bot added 4-0-x backport labels Oct 31, 2018

@codebytere codebytere merged commit acea9d1 into electron:4-0-x Nov 2, 2018

20 of 21 checks passed

ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 2, 2018

Release Notes Persisted

Honor properties.showHiddenFiles in dialog.showOpenDialog() on Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment