Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: es6ify 'Breaking Changes' and 'File' API pages #15507

Merged
merged 3 commits into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@ntocampos
Copy link
Contributor

commented Oct 31, 2018

Description of Change

This pull-request "es6ifies" code snippets in the Breaking Changes and File object documentation pages, as suggested on #14842.
cc @ckerr

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@ntocampos ntocampos requested a review from as a code owner Oct 31, 2018

@welcome

This comment has been minimized.

Copy link

commented Oct 31, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

@ntocampos Can you group all your ES6'ify PR's into one PR please? It'll make it easier to review in one go and will cause less CI jobs to run 👍

@MarshallOfSound MarshallOfSound referenced this pull request Oct 31, 2018

Closed

docs: es6ify 'File' object API page #15509

3 of 3 tasks complete
@ntocampos

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

@ntocampos Can you group all your ES6'ify PR's into one PR please? It'll make it easier to review in one go and will cause less CI jobs to run 👍

Sure. I'm gonna do this now 😄

@ntocampos ntocampos changed the title docs: es6ify 'Breaking Changes' API page docs: es6ify 'Breaking Changes' and 'File' API pages Oct 31, 2018

@ntocampos

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

Done. I've closed the other PR.

@zcbenz zcbenz force-pushed the ntocampos:es6ify-api-contract-docs branch from b5968c5 to e244c61 Dec 5, 2018

@zcbenz

zcbenz approved these changes Dec 5, 2018

@MarshallOfSound MarshallOfSound merged commit cfbea4a into electron:master Dec 5, 2018

19 of 21 checks passed

ci/circleci: mas-testing CircleCI is running your tests
Details
ci/circleci: osx-testing CircleCI is running your tests
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-lint Build #20181205.16 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Dec 5, 2018

Release Notes Persisted

no-notes
@welcome

This comment has been minimized.

Copy link

commented Dec 5, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.