New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set `windowsHide` to the old node default (backport: 3-0-x) #15514

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@trop
Contributor

trop bot commented Nov 1, 2018

Backport of #15512

See that PR for details.

Notes: fix Electron not being visible when launching in development mode on node v11

fix: explicitly set `windowsHide` to the old node default
Notes: fix Electron not being visible when launching in development mode on node v11

@trop trop bot requested a review from electron/electrocats as a code owner Nov 1, 2018

@trop trop bot added 3-0-x backport labels Nov 1, 2018

@MarshallOfSound MarshallOfSound merged commit 6d658b3 into electron:3-0-x Nov 1, 2018

11 of 14 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
appveyor: win-x64-testing-pr AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 1, 2018

Release Notes Persisted

fix Electron not being visible when launching in development mode on node v11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment