New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the "second-instance" event handler signature in the docs #15546

Merged
merged 1 commit into from Nov 2, 2018

Conversation

2 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Nov 2, 2018

Description of Change

The 'second-instance' handler receives event as its first argument.
https://github.com/electron/electron/blob/3-0-x/docs/api/app.md#event-second-instance

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: docs: fix the "second-instance" event handler signature in the docs

@alexeykuzmin alexeykuzmin requested a review from electron/docs as a code owner Nov 2, 2018

@MarshallOfSound MarshallOfSound merged commit 08ec270 into 3-0-x Nov 2, 2018

16 of 18 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 2, 2018

Release Notes Persisted

docs: fix the "second-instance" event handler signature in the docs

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 2, 2018

I have automatically backported this PR to "4-0-x", please check out #15548

@trop trop bot added in-flight/4-0-x and removed target/4-0-x labels Nov 2, 2018

@alexeykuzmin alexeykuzmin deleted the fix-second-instance-handler-signature-in-docs branch Nov 2, 2018

@trop trop bot added merged/4-0-x and removed in-flight/4-0-x labels Nov 2, 2018

@sofianguy sofianguy added this to Fixed (3.0.8) in 3.0.x Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment