New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty menu case properly #15553

Merged
merged 1 commit into from Nov 2, 2018

Conversation

2 participants
@nitsakh
Contributor

nitsakh commented Nov 2, 2018

Description of Change

Missed this return in the linux menu fix. Here it is now.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: Fixed linux empty menu crash.

@nitsakh nitsakh requested a review from electron/reviewers as a code owner Nov 2, 2018

@codebytere

🚀

@codebytere codebytere merged commit 8566f87 into 3-0-x Nov 2, 2018

15 of 17 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
appveyor: win-x64-testing AppVeyor build failed
Details
Absolute Zero
Semantic Pull Request ready to be merged or rebased
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 2, 2018

Release Notes Persisted

Fixed linux empty menu crash.

@codebytere codebytere deleted the menu-return branch Nov 2, 2018

@sofianguy sofianguy added this to Fixed (3.0.8) in 3.0.x Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment