Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remote.require() / remote.getGlobal() filtering (backport: 4-0-x) #15562

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@miniak
Copy link
Contributor

miniak commented Nov 4, 2018

Backport of #15014

See that PR for details.

Fixes #12932

Notes: Allowed filtering of remote.require() / remote.getGlobal() requests by handling remote-require / remote-get-global events.

Show resolved Hide resolved spec/api-remote-spec.js Outdated

@miniak miniak self-assigned this Nov 4, 2018

@miniak miniak force-pushed the miniak/remote-handlers-4.0 branch from bc093a5 to 27b3f3c Nov 4, 2018

@alexeykuzmin
Copy link
Contributor

alexeykuzmin left a comment

Should remain unmerged till being approved on the next Monday meeting.

@groundwater
Copy link
Member

groundwater left a comment

Discussed in morning standup: Approved feature change based on

  1. low customer-facing deploys of 4.0.x release line
  2. will revert commit if this breaks 4.0.x stabilization line

We are very early in the 4.0.x line, and downstream consumers are encouraged to report any issues related to this change.

@alexeykuzmin alexeykuzmin added 4-1-x and removed wip labels Nov 5, 2018

@alexeykuzmin alexeykuzmin merged commit f43920e into 4-0-x Nov 5, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 5, 2018

Release Notes Persisted

Allowed filtering of remote.require() / remote.getGlobal() requests by handling remote-require / remote-get-global events.

@alexeykuzmin alexeykuzmin deleted the miniak/remote-handlers-4.0 branch Nov 5, 2018

@ckerr ckerr referenced this pull request Dec 18, 2018

Closed

Draft 4.0.0 Release Notes #16117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.