New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make pyyaml an optional dependency #15565

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Nov 5, 2018

Description of Change

It's only needed to parse the native tests configurations.
Native tests still work after this change: https://circleci.com/workflow-run/529beafc-e827-4611-9bc1-14568737c9a5

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no notes

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Nov 5, 2018

Manually backported to 4-0-x in #15566.

@jkleinsc

LGTM

@jkleinsc jkleinsc merged commit 9b05381 into master Nov 5, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 5, 2018

No Release Notes

@jkleinsc jkleinsc deleted the checkout-pyyaml branch Nov 5, 2018

@nornagon

Would you consider switching the native tests data files to JSON?

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Nov 5, 2018

@nornagon Not really. I like YAML much more.
JSON syntax is not that great, with all these double quotes and braces. Absence of trailing commas and comments doesn't help too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment