New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make pyyaml an optional dependency (backport: 4-0-x) #15566

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Nov 5, 2018

Backport of #15565

See that PR for details.

Notes: no notes

build: make pyyaml an optional dependency
(cherry picked from commit d567bdb)

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Nov 5, 2018

@alexeykuzmin alexeykuzmin referenced this pull request Nov 5, 2018

Merged

build: make pyyaml an optional dependency #15565

3 of 3 tasks complete
@jkleinsc

LGTM

@jkleinsc jkleinsc merged commit 62c0f84 into 4-0-x Nov 5, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 5, 2018

No Release Notes

@jkleinsc jkleinsc deleted the 4-0-x_checkout-pyyaml branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment