New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the 'get-patch' script #15586

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@alexeykuzmin
Contributor

alexeykuzmin commented Nov 6, 2018

Description of Change

It is obsolete now.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no notes

@alexeykuzmin alexeykuzmin requested a review from nornagon Nov 6, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Nov 6, 2018

@Ali8668

Ali8668 approved these changes Nov 6, 2018

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Nov 6, 2018

@nornagon, or maybe we don't need that script at all?
The only use-case I see now for the get-patch is to backport several patches (not a range) at once:

$ ./script/get-patch \
  --repo src \
  --commit a1b2c3 a3b2c1 d4e5f6 \
  --output patches/common/chromium

... which probably shouldn't be done like that anyway =)
A proper workflow would be 1) to cherry-pick commits to a working tree, and 2) run git-export-patches.

@nornagon

This comment has been minimized.

Contributor

nornagon commented Nov 6, 2018

I agree, this script isn't needed.

@alexeykuzmin alexeykuzmin added the wip label Nov 6, 2018

chore: remove the 'get-patch' script
"script/git-export-patches" should be used instead.

@alexeykuzmin alexeykuzmin changed the title from chore: update format the "get-patch" script exports commits to chore: remove the 'get-patch' script Nov 7, 2018

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Nov 7, 2018

@nornagon removed

@alexeykuzmin alexeykuzmin removed the wip label Nov 7, 2018

@alexeykuzmin alexeykuzmin merged commit 6162d90 into master Nov 8, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 8, 2018

No Release Notes

@alexeykuzmin alexeykuzmin deleted the update-get-patch branch Nov 8, 2018

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 8, 2018

I have automatically backported this PR to "4-0-x", please check out #15643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment