Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: bypass DOM storage quota #15596
Description of Change
This updates the
cc @MarshallOfSound you mentioned you might be willing to help land this. (Thanks in advance!)
Note about documentation:
Note about running tests locally:
$ ninja -C out/Debug electron ninja: Entering directory `out/Debug' [7817/18095] ACTION //components/url_formatter/top_domains:generate_top_domains_trie(//build/toolchain/linux:clang_x64) FAILED: gen/components/url_formatter/top_domains/alexa_domains-trie-inc.cc python ../../build/gn_run_binary.py top_domain_generator /home/jquant/tmp/electron-gn/src/components/url_formatter/top_domains/alexa_domains.skeletons /home/jquant/tmp/electron-gn/src/components/url_formatter/top_domains/top_domains_trie.template gen/components/url_formatter/top_domains/alexa_domains-trie-inc.cc ./top_domain_generator: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.27' not found (required by /home/jquant/tmp/electron-gn/src/out/Debug/./libbase.so) top_domain_generator failed with exit code 1 [7818/18095] ACTION //net/http:generate_transport_security_state(//build/toolchain/linux:clang_x64) FAILED: gen/net/http/transport_security_state_static.h python ../../build/gn_run_binary.py transport_security_state_generator ../../net/http/transport_security_state_static.json ../../net/http/transport_security_state_static.pins ../../net/http/transport_security_state_static.template gen/net/http/transport_security_state_static.h ./transport_security_state_generator: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.27' not found (required by /home/jquant/tmp/electron-gn/src/out/Debug/./libbase.so) transport_security_state_generator failed with exit code 1 [7826/18095] CXX obj/third_party/ots/ots/ots.o ninja: build stopped: subcommand failed.
notes: Fixes regression regarding
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
I just threw that in there "just in case" as, once again, it seems like something that shouldn't be restricted in Electron. If it will help land this sooner I will take that out.
2 times, most recently
Nov 6, 2018
@alexeykuzmin OK, I just added some more commits and think I got all the changes you requested. Once this lands I'll open a separate PR for 3.0.x backport.
Edit: Looks like it won't be quite as simple as committing the same patch file because the hash of the files being patched has changed. So I think I'll have to regenerate it against chrome 66, not a biggy, but not a 5 minute ordeal for me either.