Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make certain values on `process` read-only #15628

Merged
merged 2 commits into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@BinaryMuse
Copy link
Member

commented Nov 7, 2018

Description of Change

Certain values on the process object should be read-only, either to match similar values (e.g. process.versions.x) or because it doesn't make sense for the values to be changed (because they represent some condition that cannot be changed).

Part of this change was slated for v2.0, but the change was not made in that version.

The values that I've made read-only are:

  • process.mas
  • process.windowsStore
  • process.versions.electron
  • process.versions.chrome
  • process.type
  • process.pid
  • process.sandboxed

I'm fairly certain there's no good reason for any of these values to not be read-only, but please comment if I've missed something.

Fixes #8083

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: fix: make certain values on process read-only

BinaryMuse added some commits Nov 7, 2018

fix: make certain properties on `process` read only:
* `mas`
* `windowsStore`
* `versions.electron`
* `versions.chrome`
* `type`
* `pid`
* `sandboxed`

@BinaryMuse BinaryMuse self-assigned this Nov 7, 2018

@BinaryMuse BinaryMuse requested review from as code owners Nov 7, 2018

@jkleinsc
Copy link
Contributor

left a comment

LGTM

@jkleinsc jkleinsc merged commit 2a8e8a0 into master Nov 8, 2018

25 of 27 checks passed

WIP work in progress
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181107.28 succeeded
Details
electron-arm64-testing Build #20181107.28 succeeded
Details
electron-lint Build #20181107.33 succeeded
Details
electron-mas-testing Build #20181107.37 succeeded
Details
electron-osx-testing Build #20181107.40 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 8, 2018

Release Notes Persisted

fix: make certain values on process read-only

@jkleinsc jkleinsc deleted the mkt/make-process-constants-read-only branch Nov 8, 2018

@BinaryMuse BinaryMuse removed the wip label Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.