New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable DCHECK in node_debugger #15649

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Nov 9, 2018

Did this in a PR that got dropped, this change should still go in though 馃憤

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Nov 9, 2018

@MarshallOfSound MarshallOfSound merged commit e7b2b93 into master Nov 9, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found

@MarshallOfSound MarshallOfSound deleted the restore-debugger-dcheck branch Nov 9, 2018

@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 9, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment