Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated touch-bar API #15650

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Nov 9, 2018

This was marked for removal way back in the 1.6.x days --> 414540b

Seems about time we should remove it 馃槅

Notes: Removed support for deprecated construction of a TouchBar with an array of items, use an options object instead

@MarshallOfSound MarshallOfSound requested a review from as a code owner Nov 9, 2018

@MarshallOfSound MarshallOfSound merged commit edf063b into master Nov 9, 2018

26 of 27 checks passed

electron-osx-testing Build #20181109.2 has test failures
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181109.3 succeeded
Details
electron-arm64-testing Build #20181109.3 succeeded
Details
electron-lint Build #20181109.3 succeeded
Details
electron-mas-testing Build #20181109.2 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 9, 2018

Release Notes Persisted

Removed support for deprecated construction of a TouchBar with an array of items, use an options object instead

@MarshallOfSound MarshallOfSound deleted the remove-touch-bar-arr branch Nov 9, 2018

@mattleff mattleff referenced this pull request Jan 22, 2019

Merged

docs: TouchBar API example #16482

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.