New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use config version 2.1 on CircleCI #15665

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Nov 10, 2018

Description of Change

Use CircleCi config version 2.1.
Release builds still look good: https://circleci.com/workflow-run/ab5a3c5e-bdc4-422d-acf3-76915c1b3b6a ("...-native-mksnapshot)" failures are unrelated, they're broken in master).

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no notes

@alexeykuzmin alexeykuzmin added the wip label Nov 10, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Nov 10, 2018

@alexeykuzmin alexeykuzmin force-pushed the circleci-config-2.1 branch from 5551ac7 to 175984b Nov 10, 2018

@alexeykuzmin alexeykuzmin removed the wip label Nov 10, 2018

@alexeykuzmin alexeykuzmin requested a review from jkleinsc Nov 10, 2018

@alexeykuzmin alexeykuzmin force-pushed the circleci-config-2.1 branch from 175984b to fdbb69a Nov 10, 2018

@nornagon nornagon merged commit 0c46a7a into master Nov 12, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 12, 2018

No Release Notes

@nornagon nornagon deleted the circleci-config-2.1 branch Nov 12, 2018

jkleinsc added a commit that referenced this pull request Nov 21, 2018

codebytere added a commit that referenced this pull request Jan 7, 2019

@codebytere codebytere referenced this pull request Jan 7, 2019

Merged

chore: revert "ci: use config version 2.1 on CircleCI" #16304

3 of 3 tasks complete

codebytere added a commit that referenced this pull request Jan 7, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment