Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow partial setting of window bounds #15677

Merged
merged 3 commits into from Nov 12, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented Nov 11, 2018

Description of Change

This PR extends the existing win.setBounds functionality by allowing developers to partially update bounds without being forced to pass in all four bounds values. No existing functionality is altered.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: allow partial setting of window bounds with win.setBounds()

@alexeykuzmin
Copy link
Contributor

left a comment

👍

Show resolved Hide resolved lib/browser/api/browser-window.js Outdated
Show resolved Hide resolved spec/api-browser-window-spec.js Outdated
Show resolved Hide resolved spec/api-browser-window-spec.js Outdated
@alexeykuzmin
Copy link
Contributor

left a comment

Nice!

Show resolved Hide resolved docs/api/browser-window.md Outdated
Improve optional bound wording in docs
Co-Authored-By: codebytere <codebytere@github.com>

@codebytere codebytere merged commit c06f023 into master Nov 12, 2018

24 of 28 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
appveyor: win-x64-testing AppVeyor build failed
Details
electron-osx-testing Build #20181112.16 has failed
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Backportable? - 4-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181112.9 succeeded
Details
electron-arm64-testing Build #20181112.9 succeeded
Details
electron-lint Build #20181112.16 succeeded
Details
electron-mas-testing Build #20181112.17 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 12, 2018

Release Notes Persisted

allow partial setting of window bounds with win.setBounds()

@codebytere codebytere deleted the extend-set-bounds branch Nov 12, 2018

@trop

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2018

I have automatically backported this PR to "4-0-x", please check out #15687

@trop trop bot added in-flight/4-0-x and removed target/4-0-x labels Nov 12, 2018

@codebytere codebytere referenced this pull request Nov 13, 2018

Merged

feat: allow partial setting of window bounds #15699

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.