New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix the build with enable_run_as_node disabled #15711

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Nov 14, 2018

Description of Change

Fix the build with enable_run_as_node = false on Mac and Linux.

Builds with enable_run_as_node = false before the change:

Builds with enable_run_as_node = false after the change:

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no notes

@alexeykuzmin alexeykuzmin added the wip label Nov 14, 2018

@alexeykuzmin alexeykuzmin requested a review from electron/reviewers as a code owner Nov 14, 2018

@alexeykuzmin alexeykuzmin added 4-0-x target/4-0-x and removed 4-0-x labels Nov 14, 2018

Show resolved Hide resolved atom/app/atom_main.cc Outdated

@alexeykuzmin alexeykuzmin force-pushed the fix-build-with-enable_run_as_node-disabled branch 3 times, most recently from 9e5dfe5 to 1bee420 Nov 15, 2018

@miniak miniak force-pushed the fix-build-with-enable_run_as_node-disabled branch from 1bee420 to 9360e6d Jan 10, 2019

@miniak

miniak approved these changes Jan 11, 2019

@alexeykuzmin alexeykuzmin removed the wip label Jan 11, 2019

@alexeykuzmin alexeykuzmin force-pushed the fix-build-with-enable_run_as_node-disabled branch from 9360e6d to e0b2ed0 Jan 11, 2019

@alexeykuzmin

This comment has been minimized.

Copy link
Contributor

alexeykuzmin commented Jan 11, 2019

@deepak1556 Can you please re-review it?

@deepak1556
Copy link
Member

deepak1556 left a comment

LGTM

@codebytere codebytere merged commit 3cb9aad into master Jan 11, 2019

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 11, 2019

No Release Notes

@codebytere codebytere deleted the fix-build-with-enable_run_as_node-disabled branch Jan 11, 2019

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Jan 11, 2019

I have automatically backported this PR to "4-0-x", please check out #16367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment