New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use different directory for generated breakpad symbols #15716

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@jkleinsc
Contributor

jkleinsc commented Nov 14, 2018

Description of Change

Fixes #15054.

Our CI was timing out on generating breakpad symbols. It turns out it was erroring out on trying to read the destination directory electron.breakpad.syms as a file here:
https://cs.chromium.org/chromium/src/components/crash/content/tools/generate_breakpad_symbols.py?q=potential_symbol_files&sq=package:chromium&g=0&l=245
This is because of this line which happens to match our directory name:
https://cs.chromium.org/chromium/src/components/crash/content/tools/generate_breakpad_symbols.py?q=potential_symbol_files&sq=package:chromium&g=0&l=243

This PR fixes the issue by changing what directory we save the breakpad symbols to.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Nov 14, 2018

@nornagon

This seems reasonable to me but I'm nervous that there might have been a specific reason for naming the directory electron.breakpad.syms. I guess we'll find out?

@jkleinsc jkleinsc merged commit b53a858 into master Nov 14, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 14, 2018

No Release Notes

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 14, 2018

I have automatically backported this PR to "4-0-x", please check out #15720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment