New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore missing .lproj directories #15721

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@nornagon
Contributor

nornagon commented Nov 14, 2018

The empty lproj directories help macOS to understand what locales the app supports.

Fixes #15714

Checklist

  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines

Release Notes

Notes: restore missing .lproj directories in macOS bundle

fix: restore missing .lproj directories
the empty lproj directories help macOS to understand what locales the app supports

@nornagon nornagon requested review from kwonoj and codebytere Nov 14, 2018

@nornagon nornagon requested a review from electron/reviewers as a code owner Nov 14, 2018

@kwonoj

kwonoj approved these changes Nov 14, 2018

It looks ok on my eye, but might need additional review to confirm changes (as I have lacks of knowledge around build scripts)

@nornagon

This comment has been minimized.

Contributor

nornagon commented Nov 15, 2018

Merging because CI failures are unrelated.

@nornagon nornagon merged commit c8860d0 into master Nov 15, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Nov 15, 2018

Release Notes Persisted

restore missing .lproj directories in macOS bundle

@nornagon nornagon deleted the lproj-dirs branch Nov 15, 2018

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

fix: restore missing .lproj directories (electron#15721)
the empty lproj directories help macOS to understand what locales the app supports

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

fix: restore missing .lproj directories (electron#15721)
the empty lproj directories help macOS to understand what locales the app supports
@nornagon

This comment has been minimized.

Contributor

nornagon commented Nov 19, 2018

/trop run backport

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 19, 2018

The backport process for this PR has been manually initiated, here we go! :D

@trop

This comment has been minimized.

Contributor

trop bot commented Nov 19, 2018

I have automatically backported this PR to "4-0-x", please check out #15769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment