Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always disable setuid sandbox on linux #15722

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

commented Nov 14, 2018

Description of Change

Previously, when --enable-mixed-sandbox was passed, the setuid sandbox would not be disabled. In other places in the code we assume that the setuid sandbox is not in use.

Checklist

Release Notes

Notes: fix an issue where on Linux, the setuid sandbox was incorrectly enabled when passing --enable-mixed-sandbox

@nornagon nornagon requested a review from zcbenz Nov 14, 2018

@nornagon nornagon requested a review from as a code owner Nov 14, 2018

@nornagon nornagon force-pushed the always-disable-setuid-sandbox branch from d42ee54 to 34de1a5 Nov 14, 2018

@codebytere
Copy link
Member

left a comment

this nukes the need for the upstream, yeah?

@nornagon

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

for upstream what?

@nornagon

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

Merging because mac CI is broken.

@nornagon nornagon merged commit 20116d7 into master Nov 15, 2018

25 of 27 checks passed

electron-mas-testing Build #20181115.5 has failed
Details
electron-osx-testing Build #20181115.4 has failed
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181114.15 succeeded
Details
electron-arm64-testing Build #20181114.15 succeeded
Details
electron-lint Build #20181114.17 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 15, 2018

Release Notes Persisted

fix an issue where on Linux, the setuid sandbox was incorrectly enabled when passing --enable-mixed-sandbox

@nornagon nornagon deleted the always-disable-setuid-sandbox branch Nov 15, 2018

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

neo291 added a commit to neo291/electron that referenced this pull request Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.