Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: promisify app.getFileIcon() #15742
Description of Change
Co-authored-by: Charles Kerr firstname.lastname@example.org
ckerr left a comment
The pieces that are here LGTM. Nice work!
Before we start merging PRs though I think we need a plan to make the API churn more managable to Electron app developers, e.g. the framework discussed at electron/maintainers#159 (CC @alexeykuzmin, @MarshallOfSound).
Additionally, whatever plan we follow should be in a public repo. E.g. if we still like 159 we should move it verbatim into
The initial plan for promisification hinged on waiting until Node 8 (which bundled
However, this means that we can't, then, batch convert over all relevant methods at once, and need to do it in this more piecemeal manner. My proposal would be that we maintain a public project board with our progress on this issue, in addition to an issue in maintainers, and merge these piecemeal rather than bottleneck on each method being converted so that we can flag them all at once.
What are y'all's thoughts?
^convo continued in another issue