Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify win.capturePage() #15743

Merged
merged 8 commits into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented Nov 16, 2018

Description of Change

This PR promisifies win.capturePage.

Todo:

  • Docs
  • Specs

/cc @ckerr @deepak1556

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: promisify win.capturePage()

Co-authored-by: Charles Kerr ckerr@github.com

@codebytere codebytere requested review from as code owners Nov 16, 2018

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

This should go through our deprecation cycle right? We should probably add a JS side wrapper so that callback-style still works but with a deprecation warning

@codebytere codebytere changed the title feat: promisify win.capturePage feat: promisify win.capturePage() Nov 18, 2018

@codebytere codebytere force-pushed the promisify-capturePage branch from 1020f35 to 5c5286b Nov 19, 2018

Show resolved Hide resolved docs/api/browser-window.md Outdated
Show resolved Hide resolved docs/api/browser-window.md Outdated
Show resolved Hide resolved docs/api/browser-window.md Outdated
Show resolved Hide resolved docs/api/browser-window.md Outdated

codebytere added some commits Nov 16, 2018

@codebytere codebytere force-pushed the promisify-capturePage branch from d2bf372 to 7063cd9 Nov 26, 2018

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

@MarshallOfSound rebased and updated!

[NativeImage](native-image.md) that stores data of the snapshot. Omitting
`rect` will capture the whole visible page.
be called with `callback(image)`. The `image` is an instance of [NativeImage](native-image.md)
that stores data of the snapshot. Omitting `rect` will capture the whole visible page.

This comment has been minimized.

Copy link
@felixrieseberg

felixrieseberg Nov 27, 2018

Member

that stores data of the snapshot could be clearer, but that's the only thing I could find with this PR. The rest looks and it's honestly a nit.

@codebytere codebytere force-pushed the promisify-capturePage branch from d2e7de2 to 848defd Nov 27, 2018

@codebytere codebytere merged commit 41c2685 into master Nov 28, 2018

25 of 27 checks passed

electron-osx-testing Build #20181127.41 has test failures
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181127.22 succeeded
Details
electron-arm64-testing Build #20181127.21 succeeded
Details
electron-lint Build #20181127.24 succeeded
Details
electron-mas-testing Build #20181127.41 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 28, 2018

Release Notes Persisted

promisify win.capturePage()

@codebytere codebytere deleted the promisify-capturePage branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.