Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: make 'setParentWindow' compatible under Windows #15775
Description of Change
Make 'win.setParentWindow(parent)' available also under Windows.
Notes: 'win.setParentWindow(parent)' available also under Windows
brenca left a comment
I'm fine with the Winapi parts, but it would be nice to get some tests for this if we can, and if possible, we should get those
nornagon left a comment
I think duplicating those constants is OK, they're unlikely to change. But the
I'm not familiar enough with the windows API to say whether this is correct, but it certainly looks complicated
About the test:
About the constants:
But for the final merge I ask to wait some more time, I'll want to check one more strange thing I've noticed just now, that I hadn't noticed before.
Nov 21, 2018
Now I've finished!
At the end, by analyzing one more time and more deeper with the Spy++ the window native creation as a non-child compared to a child, it resulted that the window styles are the same for a child and a non-child, without need to change them, the only thing that need to be change is the owner.
Seems that in some point of the chromium code the
Moreover, being the style the same for a non-child and a child window is removed the need of the constants derived from chromium and is automatically solved also the possible constants duplication doubt.
Thanks for your patience and sorry for the delay.