Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update mojave-dark-mode-guide.md #15888

Merged
merged 3 commits into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@JB1905
Copy link
Contributor

commented Nov 29, 2018

Add info about dark mode support in electron-builder

Description of Change

Add info about dark mode support in electron-builder in mojave-dark-mode-guide.md

Release Notes
Notes: Add info about dark mode support in electron-builder in mojave-dark-mode-guide.md

Update mojave-dark-mode-guide.md
Add info about dark mode support in electron-builder

@JB1905 JB1905 requested a review from as a code owner Nov 29, 2018

@welcome

This comment has been minimized.

Copy link

commented Nov 29, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codebytere codebytere requested a review from MarshallOfSound Nov 29, 2018

@codebytere

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@JB1905 it looks like you deleted the issue template, please go back and fill that out. Missing fields will fail CI checks like the release-notescheck.

@ckerr

ckerr approved these changes Nov 29, 2018

@ckerr

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

(FYI cc @MarshallOfSound)

@JB1905 JB1905 changed the title Update mojave-dark-mode-guide.md docs: update mojave-dark-mode-guide.md Nov 29, 2018

@@ -24,8 +24,7 @@ to set the `NSRequiresAquaSystemAppearance` key in your app's `Info.plist` file
</plist>
```

If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager) or
[`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) you can set the
If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager), [`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) or [`electron-builder` >= 20.37.0](https://github.com/electron-userland/electron-builder) you can set the

This comment has been minimized.

Copy link
@MarshallOfSound

MarshallOfSound Nov 29, 2018

Member

I think the builder reference should be put in a new paragraph beneath this one with its own links to builders option name. Builders option is not the same as forges / packagers.

@MarshallOfSound MarshallOfSound merged commit 1672cff into electron:master Dec 1, 2018

21 of 23 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
electron-lint Build #20181130.16 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Dec 1, 2018

Release Notes Persisted

Add info about dark mode support in electron-builder in mojave-dark-mode-guide.md

@welcome

This comment has been minimized.

Copy link

commented Dec 1, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.