Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update mojave-dark-mode-guide.md #15888

Merged
merged 3 commits into from Dec 1, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -24,8 +24,7 @@ to set the `NSRequiresAquaSystemAppearance` key in your app's `Info.plist` file
</plist>
```

If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager) or
[`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) you can set the
If you are using [`electron-packager` >= 12.2.0](https://github.com/electron-userland/electron-packager), [`electron-forge` >= 6](https://github.com/electron-userland/electron-forge) or [`electron-builder` >= 20.37.0](https://github.com/electron-userland/electron-builder) you can set the

This comment has been minimized.

Copy link
@MarshallOfSound

MarshallOfSound Nov 29, 2018

Member

I think the builder reference should be put in a new paragraph beneath this one with its own links to builders option name. Builders option is not the same as forges / packagers.

[`darwinDarkModeSupport`](https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#darwindarkmodesupport)
This conversation was marked as resolved by MarshallOfSound

This comment has been minimized.

Copy link
@MarshallOfSound

MarshallOfSound Nov 30, 2018

Member

My comment was more about the fact that the builder option is not called darwinDarkModeSupport. It should be in it's own paragraph below and reference the builder option name and docs.

option when packaging and this key will be set for you.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.