New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct windowMenu role on MacOS #15930

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Dec 3, 2018

Description of Change

Resolves #15912.

Updates windowMenu MenuItem role to more accurately reflect the default window menu on MacOS. Also updates the default app to use this role.

/cc @sindresorhus @BinaryMuse

Checklist

Release Notes

Notes: correct windowMenu MenuItem role on MacOS

@codebytere codebytere requested review from electron/docs as code owners Dec 3, 2018

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Dec 3, 2018

Is this technically semver/major?

@codebytere codebytere changed the title from fix: make windowMenu role correct on MacOS to fix: correct windowMenu role on MacOS Dec 3, 2018

@codebytere

This comment has been minimized.

Member

codebytere commented Dec 3, 2018

Maybe? i'd say fix is arguable since it's incorrect for MacOS as it currently stands

@BinaryMuse

This comment has been minimized.

Member

BinaryMuse commented Dec 3, 2018

Hm, I could see the argument each way. Even though the behavior is technically incorrect, if fixing it could potentially cause apps or behavior to change in a non-backward-compat way, I'd argue that it's probably better a semver/major change too.

@BinaryMuse

Not super familiar with this but it seems okay to me

@codebytere codebytere merged commit a1a431e into master Dec 3, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Dec 3, 2018

Release Notes Persisted

correct windowMenu MenuItem role on MacOS

@codebytere codebytere deleted the fix-macos-windowmenu branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment