New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enable arm embedded builtins #15939

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@jkleinsc
Contributor

jkleinsc commented Dec 3, 2018

Description of Change

This PR reverts 8ec3bc0 and fixes the underlying issue of native_mksnapshot failing to build by setting v8_enable_embedded_builtins = false.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Dec 3, 2018

@jkleinsc jkleinsc requested a review from deepak1556 Dec 3, 2018

@zcbenz

zcbenz approved these changes Dec 4, 2018

@zcbenz zcbenz merged commit 77f7383 into master Dec 4, 2018

20 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Dec 4, 2018

No Release Notes

@zcbenz zcbenz deleted the enable_arm_embedded_builtins branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment