Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated modules internally using remote.require in sandboxed renderer context #15957

Merged
merged 1 commit into from Jan 24, 2019

Conversation

@miniak
Copy link
Contributor

commented Dec 5, 2018

Description of Change

Remove APIs deprecated in #15145. Deprecations are in 5.0 release.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Removed deprecated modules internally using remote.require in sandboxed renderer context. Use remote.require explicitly instead (unless the remote module is disabled).

@miniak miniak requested review from as code owners Dec 5, 2018

@miniak miniak force-pushed the miniak/remove-deprecated branch 4 times, most recently from 86cf71e to 8c04682 Dec 5, 2018

@miniak miniak self-assigned this Dec 5, 2018

@miniak miniak force-pushed the miniak/remove-deprecated branch 2 times, most recently from 7431ba2 to f7aa529 Dec 17, 2018

@miniak miniak force-pushed the miniak/remove-deprecated branch from f7aa529 to e9673f2 Dec 27, 2018

@miniak miniak force-pushed the miniak/remove-deprecated branch from e9673f2 to ab014a0 Jan 23, 2019

@codebytere codebytere merged commit 713df08 into master Jan 24, 2019

23 of 27 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
electron-arm-testing Build #20190123.4 has failed
Details
electron-arm64-testing Build #20190123.4 has failed
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-lint Build #20190123.6 succeeded
Details
electron-mas-testing Build #20190123.5 succeeded
Details
electron-osx-testing Build #20190123.3 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 24, 2019

Release Notes Persisted

Removed deprecated modules internally using remote.require in sandboxed renderer context. Use remote.require explicitly instead (unless the remote module is disabled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.