New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Chromium 71.0.3578.98 #15966

Merged
merged 53 commits into from Jan 12, 2019

Conversation

Projects
None yet
4 participants
@deepak1556
Copy link
Member

deepak1556 commented Dec 6, 2018

Description of Change

Refs https://github.com/orgs/electron/projects/26

BREAKING CHANGE

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Upgrade to Chromium 71.0.3578.98

@deepak1556 deepak1556 requested review from electron/notifications as code owners Dec 6, 2018

- # Enables Widevine key system support. Enabled by default in Google Chrome or
- # on Android. Can be optionally enabled in Chromium.
- enable_widevine = is_chrome_branded || is_android
+ # Allow Widevine key system support in Chromium.

This comment has been minimized.

@nornagon

nornagon Dec 6, 2018

Contributor

nit: we don't need to patch this comment

@deepak1556 deepak1556 force-pushed the chromium-upgrade/71 branch 2 times, most recently from 11f7703 to c557736 Dec 6, 2018

@zcbenz zcbenz force-pushed the chromium-upgrade/71 branch from 06cba7c to ec4c329 Dec 14, 2018

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Dec 14, 2018

I'm rebasing this branch to fix conflict with webview fixes.

@zcbenz zcbenz force-pushed the chromium-upgrade/71 branch from ec4c329 to 8e6ea7d Dec 14, 2018

@deepak1556 deepak1556 force-pushed the chromium-upgrade/71 branch 2 times, most recently from 479c3cd to 5a24bfd Dec 24, 2018

@nornagon nornagon force-pushed the chromium-upgrade/71 branch from b82b054 to 957a3d3 Jan 3, 2019

@deepak1556 deepak1556 changed the title [WIP] feat: Upgrade to Chromium 71.0.3578.80 [WIP] feat: Upgrade to Chromium 71.0.3578.98 Jan 4, 2019

@deepak1556 deepak1556 force-pushed the chromium-upgrade/71 branch 3 times, most recently from c1e0e1d to c8e461b Jan 4, 2019

Show resolved Hide resolved BUILD.gn
Show resolved Hide resolved BUILD.gn
@@ -182,30 +183,21 @@ void AtomSandboxedRendererClient::DidCreateScriptContext(
!IsDevToolsExtension(render_frame))
return;

// Wrap the bundle into a function that receives the binding object as
// argument.

This comment has been minimized.

@nornagon

nornagon Jan 8, 2019

Contributor

is this comment still accurate?

This comment has been minimized.

@deepak1556

deepak1556 Jan 10, 2019

Author Member

Yup the per process loader essentially does the same, it runs the provided source under a scope that has these arguments in the global variable.

v8::Isolate* isolate = context->GetIsolate();
v8::HandleScope handle_scope(isolate);
v8::Context::Scope context_scope(context);

// Wrap the bundle into a function that receives the isolatedWorld as
// an argument.

This comment has been minimized.

@nornagon

nornagon Jan 8, 2019

Contributor

is this comment still accurate?

@deepak1556 deepak1556 force-pushed the chromium-upgrade/71 branch from 5572c19 to f41f13b Jan 10, 2019

@deepak1556 deepak1556 changed the title [WIP] feat: Upgrade to Chromium 71.0.3578.98 feat: Upgrade to Chromium 71.0.3578.98 Jan 10, 2019

@deepak1556 deepak1556 requested review from nornagon and zcbenz Jan 10, 2019

@nornagon
Copy link
Contributor

nornagon left a comment

lgtm with some comments

Show resolved Hide resolved spec/api-session-spec.js

namespace {

napi_value Print(napi_env env, napi_callback_info info) {

This comment has been minimized.

@nornagon

nornagon Jan 10, 2019

Contributor

Why is this called Print? Perhaps it should be called Echo?

try {
window.localStorage
} catch (e) {
message = e.message
const {ipcRenderer} = require('electron')
ipcRenderer.send('local-storage-response', e.message)
}

This comment has been minimized.

@nornagon

nornagon Jan 10, 2019

Contributor

This looks like it won't send a message back if it doesn't throw, which will just make the test time out. Let's make tests fail fast & with useful error messages rather than dealing with yet another "test timed out" failure.

@zcbenz

zcbenz approved these changes Jan 11, 2019

@nornagon nornagon force-pushed the chromium-upgrade/71 branch from f41f13b to 7fa67e1 Jan 11, 2019

deepak1556 and others added some commits Dec 7, 2018

fix: correctly register WebView tag
Due to the migration to Custom Elements V1, the WebView element has to
be defined in the DOM's context. To order to make WebView work with the
contextIsolation, the definition of WebView element has been moved to a
separate file.
spec: disable ses.getBlobData
per frame scheme previlege api are no longer available,
scheme needs to be registered on the browser side with
AtomContentClient::AddAdditionalSchemes

@nornagon nornagon force-pushed the chromium-upgrade/71 branch from 7fa67e1 to 8bec8e5 Jan 11, 2019

@nornagon nornagon merged commit 52fe92d into master Jan 12, 2019

40 of 44 checks passed

ci/circleci: linux-arm64-native-mksnapshot Your tests failed on CircleCI
Details
ci/circleci: linux-x64-chromium-unittests Your tests failed on CircleCI
Details
ci/circleci: linux-x64-disabled-unittests Your tests failed on CircleCI
Details
ci/circleci: linux-x64-unittests Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-chromedriver Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-native-mksnapshot Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-release Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-release-summary Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-chromedriver Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-release Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout-for-native-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout-for-native-tests-with-no-patches Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-chromedriver Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-release Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-release-summary Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-release-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-verify-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-verify-mksnapshot Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-chromedriver Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-release Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-release-summary Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-release-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-verify-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-verify-mksnapshot Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 12, 2019

Release Notes Persisted

Upgraded to Chromium 71.0.3578.98.

@nornagon nornagon deleted the chromium-upgrade/71 branch Jan 12, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment