New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add webui_resources to pak #16009

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
5 participants
@nornagon
Copy link
Contributor

nornagon commented Dec 11, 2018

fixes #16006

Checklist

  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@zcbenz

zcbenz approved these changes Dec 11, 2018

@codebytere codebytere merged commit f3c64ea into master Dec 11, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 11, 2018

No Release Notes

@codebytere codebytere deleted the webui-resources branch Dec 11, 2018

@bughit

This comment has been minimized.

Copy link
Contributor

bughit commented Dec 11, 2018

Please backport this to 4.0, it regressed there.

@nornagon

This comment has been minimized.

Copy link
Contributor

nornagon commented Dec 11, 2018

/trop run backport

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 11, 2018

The backport process for this PR has been manually initiated, here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 11, 2018

I have automatically backported this PR to "4-0-x", please check out #16023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment