New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Cleanup build dirs on Azure Devops #16047

Merged
merged 5 commits into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Copy link
Contributor

jkleinsc commented Dec 13, 2018

Description of Change

Azure Devops (aks VSTS) was not properly cleaning up directories after builds which meant our CI VMs were running out of disk space. This PR ensures that the directories are deleted after the build.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

jkleinsc added some commits Dec 10, 2018

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Dec 13, 2018

@codebytere
Copy link
Member

codebytere left a comment

🚮

@jkleinsc jkleinsc merged commit 0e6db8f into master Dec 13, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 13, 2018

No Release Notes

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 13, 2018

I have automatically backported this PR to "4-0-x", please check out #16048

@trop trop bot added in-flight/4-0-x and removed target/4-0-x labels Dec 13, 2018

@jkleinsc jkleinsc deleted the cleanup-build-dirs-vsts branch Dec 13, 2018

@trop trop bot added merged/4-0-x and removed in-flight/4-0-x labels Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment