Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow immediate MacOS notifications #16060

Merged
merged 4 commits into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Dec 13, 2018

Description of Change

Resolves #15789.

Refactors notification posting on MacOS to allow for some notifications to deliver immediately regardless of whether or not the subscribing app is active or not.

Only NSDistributedNotificationCenter has access to the deliverImmediate selector, so I split out the DoPostNotification helper into the calling functions as it now make more sense for each to just call the methods themselves rather than call out to a helper. deliverImmediate was also added as an optional new param so as to maintain backwards compat.

/cc @ckerr

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: allow for MacOS notifications to be immediately delivered

@codebytere codebytere requested review from as code owners Dec 13, 2018

@codebytere codebytere changed the title feat: allow immediate MacOS notifications [wip] feat: allow immediate MacOS notifications Dec 13, 2018

@codebytere codebytere changed the title [wip] feat: allow immediate MacOS notifications feat: allow immediate MacOS notifications Dec 13, 2018

Show resolved Hide resolved docs/api/system-preferences.md Outdated
Show resolved Hide resolved atom/browser/api/atom_api_system_preferences_mac.mm
update docs/api/system-preferences.md
Co-Authored-By: codebytere <codebytere@github.com>
@ckerr

ckerr approved these changes Dec 14, 2018

@codebytere codebytere merged commit 280f9bf into master Dec 14, 2018

25 of 27 checks passed

appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181214.21 succeeded
Details
electron-arm64-testing Build #20181214.21 succeeded
Details
electron-lint Build #20181214.13 succeeded
Details
electron-mas-testing Build #20181214.22 succeeded
Details
electron-osx-testing Build #20181214.30 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Dec 14, 2018

Release Notes Persisted

allow for MacOS notifications to be immediately delivered

@codebytere codebytere deleted the notification-delivery-immediate branch Dec 14, 2018

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

Hey @codebytere, the release notes here are confusing because "notification" sounds like it means Notification. Can you edit @release-clerk's notes and clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.