Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register webview in main world when using contextIsolation #16067

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Copy link
Member

commented Dec 14, 2018

Description of Change

Fix WebView tag not registered in main world when using contextIsolation.

Close #9736.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Fix <webview> tag not working when using contextIsolation.

@zcbenz zcbenz added the target/4-0-x label Dec 14, 2018

@zcbenz zcbenz requested a review from as a code owner Dec 14, 2018

@zcbenz zcbenz removed the target/4-0-x label Dec 14, 2018

@zcbenz

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

Need to have #16065 merged before backporting to 4-0-x.

@zcbenz zcbenz merged commit 8584c2f into master Dec 14, 2018

27 of 28 checks passed

Backportable? - 4-0-x Cancelled
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181214.8 succeeded
Details
electron-arm64-testing Build #20181214.8 succeeded
Details
electron-lint Build #20181214.4 succeeded
Details
electron-mas-testing Build #20181214.7 succeeded
Details
electron-osx-testing Build #20181214.8 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Dec 14, 2018

Release Notes Persisted

Fix <webview> tag not working when using contextIsolation.

@zcbenz zcbenz deleted the fix-webview-in-contextisolation branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.