Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] feat: promisify cookies API #16068

Closed
wants to merge 15 commits into from
Closed

[wip] feat: promisify cookies API #16068

wants to merge 15 commits into from

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Dec 14, 2018

Description of Change

Promisifies the Cookie API.

TODO:

  • promisify FlushStore
  • wrap flushStore() with deprecate.promisfy()
  • finish updating tests
  • remove the excess tracer LOG(INFO) statements in atom_api_cookies.cc
  • other cleanup: currently has unnecessary exploratory code that shouldn't go into prod
  • update documentation for all four methods

CC @codebytere

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Updated Cookies API to use Promises.

@ckerr ckerr requested review from a team December 14, 2018 03:42
@ckerr ckerr changed the title [wip] feat: promisify cookie's API [wip] feat: promisify cookies API Dec 14, 2018
@ckerr
Copy link
Member Author

ckerr commented Jan 19, 2019

Superceded by #16464

@ckerr ckerr closed this Jan 19, 2019
@ckerr ckerr deleted the promisify-cookies branch January 19, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants