Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose app accessibility status api #16119

Merged
merged 2 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented Dec 18, 2018

Description of Change

Resolves #16090.

Exposes an api through System Preferences allowing an app to determine whether or not it's been designated a trusted accessibility client, where that means an app that is allowed to modify the way users interact with their computer.

This API takes a prompt argument; if false is passed then the result will be returned silently, and if true is passed then a dialog (like the one below) will be shown.

screen shot 2018-12-17 at 8 32 33 pm

/cc @miniak @4ndv

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: Exposes an API to allow apps to determine their status as a trusted accessibility client.

@codebytere codebytere requested review from as code owners Dec 18, 2018

@miniak

miniak approved these changes Dec 18, 2018

@miniak

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

@codebytere you had a small bug in the code, passing @YES both when prompt was true and false. Fixed that + eliminated duplicate code as C++ bool can be used as Objective-C BOOL literal (https://clang.llvm.org/docs/ObjectiveCLiterals.html)

@miniak miniak force-pushed the accessibility-check branch from da555eb to 0b8f8ca Dec 18, 2018

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2018

ah ok, i wasn't sure if objc bool literal could be coerced from c++ bools

@jkleinsc
Copy link
Contributor

left a comment

LGTM

@jkleinsc jkleinsc merged commit a58d989 into master Dec 18, 2018

26 of 27 checks passed

Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181218.10 succeeded
Details
electron-arm64-testing Build #20181218.10 succeeded
Details
electron-lint Build #20181218.10 succeeded
Details
electron-mas-testing Build #20181218.12 succeeded
Details
electron-osx-testing Build #20181218.13 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Dec 18, 2018

Release Notes Persisted

Exposes an API to allow apps to determine their status as a trusted accessibility client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.