Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing require in chromium-spec #16153

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@zcbenz
Copy link
Member

commented Dec 20, 2018

Fix the failing CI on master branch.

Notes: no-notes.

@zcbenz zcbenz requested a review from as a code owner Dec 20, 2018

@codebytere codebytere referenced this pull request Dec 20, 2018

Merged

chore: make nugget quiet by default #16147

4 of 4 tasks complete

@zcbenz zcbenz merged commit 4ff7976 into master Dec 20, 2018

27 checks passed

Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm-testing Build #20181220.5 succeeded
Details
electron-arm64-testing Build #20181220.5 succeeded
Details
electron-lint Build #20181220.5 succeeded
Details
electron-mas-testing Build #20181220.5 succeeded
Details
electron-osx-testing Build #20181220.8 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Dec 20, 2018

No release notes

@zcbenz zcbenz deleted the fix-lint-error branch Dec 20, 2018

@nornagon

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

Looks like clerk is a bit sensitive to the . at the end of no-notes. cc @codebytere and @MarshallOfSound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.