New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @types/node dep #16174

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented Dec 21, 2018

Description of Change

Resolves #16173.

Updates @types/node from v8.0.24 => v10.12.18.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: no-notes

@codebytere codebytere requested a review from electron/electrocats as a code owner Dec 21, 2018

@jkleinsc
Copy link
Contributor

jkleinsc left a comment

LGTM

@jkleinsc jkleinsc merged commit 18ca4b6 into master Dec 21, 2018

21 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 21, 2018

No Release Notes

@jkleinsc jkleinsc deleted the update-types-node branch Dec 21, 2018

@jkleinsc jkleinsc restored the update-types-node branch Dec 21, 2018

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Dec 21, 2018

/trop run backport

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 21, 2018

The backport process for this PR has been manually initiated, here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Dec 21, 2018

I have automatically backported this PR to "4-0-x", please check out #16177

@trop trop bot added in-flight/4-0-x and removed target/4-0-x labels Dec 21, 2018

@jkleinsc jkleinsc deleted the update-types-node branch Dec 21, 2018

@trop trop bot added merged/4-0-x and removed in-flight/4-0-x labels Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment