Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flexible autoresize for BrowserViews #16184

Merged
merged 3 commits into from Jan 31, 2019

Conversation

@summeroff
Copy link
Contributor

commented Dec 24, 2018

Flexible autoresize for BrowserViews in BrowserWindow

As support for multy BrowserView in BrowserWIndow added in PR #16148. How current autoresize options work is not always suitable to what app developer can need when some browser views resize together. It is because width and height autoresize modes change view by same amount what windows changed.

This commit add two new options horizontal and vertical. With this options enabled, a browserview will autoresize not only dimensions but position on window too. And in a way that keep proportions the same.

For example we add two views.
view1 x:100 width:100 and view2 x:200 width:200 in window with width 400.
And if user change window width to 800 then autoresize updates views to view1 x:200 width:200 and view2 x:400 width:400

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: Added flexible autoresize option for BrowserViews in BrowserWindow.

@summeroff summeroff requested review from as code owners Dec 24, 2018

@summeroff summeroff force-pushed the stream-labs:sl_browser_view_autoresize_master branch from 6dce162 to 6ef9b13 Jan 7, 2019

@zcbenz zcbenz force-pushed the stream-labs:sl_browser_view_autoresize_master branch 2 times, most recently from 47c040b to 73397b1 Jan 23, 2019

@zcbenz zcbenz force-pushed the stream-labs:sl_browser_view_autoresize_master branch from 73397b1 to 614b05a Jan 30, 2019

@zcbenz

zcbenz approved these changes Jan 31, 2019

@zcbenz zcbenz merged commit 49ec7e1 into electron:master Jan 31, 2019

18 of 23 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
ci/circleci: linux-ia32-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Artifact Comparison
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
electron-lint Build #20190130.9 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 31, 2019

Release Notes Persisted

Added flexible autoresize option for BrowserViews in BrowserWindow.

summeroff added a commit to stream-labs/electron that referenced this pull request Apr 22, 2019

feat: flexible autoresize for BrowserViews (electron#16184)
* feat: flexible autoresize for BrowserViews

* fix: change to static_cast

* Slight format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.