Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Show the code of adding devtools extension #16186

Merged
merged 5 commits into from Jan 15, 2019

Conversation

Projects
None yet
3 participants
@moshfeu
Copy link
Contributor

commented Dec 24, 2018

Description of Change

Just to show the path is not enough because it's not working - nodejs/node#684 (comment).
Replaced with a working code.

Checklist

  • PR description included (and stakeholders cc'd I don't know who they are)
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: adding devtools extension docs improvement

@moshfeu moshfeu requested a review from as a code owner Dec 24, 2018

@moshfeu

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2018

@zcbenz Can you take a look? I'm not sure why the tests are failing. I changed only the docs.

Thanks!

Show resolved Hide resolved docs/tutorial/devtools-extension.md Outdated
@zcbenz

This comment has been minimized.

Copy link
Member

commented Dec 25, 2018

The failing tests are not related to this PR, they can be ignored.

@moshfeu

This comment has been minimized.

Copy link
Contributor Author

commented Dec 25, 2018

Thanks @zcbenz !

Show resolved Hide resolved docs/tutorial/devtools-extension.md Outdated

moshfeu added a commit to moshfeu/electron that referenced this pull request Jan 8, 2019

@moshfeu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

@miniak Done. I think that the fail tests is not related to my change.

@moshfeu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

@zcbenz can you take a look please?

@zcbenz zcbenz force-pushed the moshfeu:update-devtools-extension-doc branch from ac2a506 to 4699d83 Jan 15, 2019

@zcbenz

zcbenz approved these changes Jan 15, 2019

@zcbenz zcbenz merged commit 05755ba into electron:master Jan 15, 2019

21 of 23 checks passed

ci/circleci: mas-testing-tests Your tests failed on CircleCI
Details
ci/circleci: osx-testing-tests CircleCI is running your tests
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
electron-lint Build #20190115.9 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 15, 2019

Release Notes Persisted

adding devtools extension docs improvement

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.