Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose systemPreferences.getSystemColor() #16248

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@codebytere
Copy link
Member

commented Jan 3, 2019

Description of Change

Partially resolves #16246. There will be a second follow-up PR that adds MacOS support for Dynamic Colors to the existing systemPreferences.getColor() method that already exists for Windows.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: Add a way to query for system colors on MacOS via systemPreferences.getSystemColor().

@codebytere codebytere requested review from as code owners Jan 3, 2019

@codebytere codebytere changed the title feat: expose systemPreferences.getSystemColor() for MacOS feat: expose systemPreferences.getSystemColor() Jan 3, 2019

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2019

Seeing very weird error on mac builds; it builds fine locally 🤔

../../electron/atom/browser/api/atom_api_system_preferences_mac.mm:386:27: error: class method '+systemBlueColor' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
           sysColor = [NSColor systemBlueColor];

@codebytere codebytere force-pushed the add-system-color branch from b8f3b3b to 208ea1f Jan 3, 2019

@miniak

miniak approved these changes Jan 3, 2019

@BinaryMuse
Copy link
Member

left a comment

📝

@codebytere codebytere force-pushed the add-system-color branch from 0be9257 to 58cc6f2 Jan 3, 2019

@codebytere codebytere merged commit 0389215 into master Jan 3, 2019

25 of 27 checks passed

electron-arm-testing Build #20190103.33 has failed
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm64-testing Build #20190103.33 succeeded
Details
electron-lint Build #20190103.43 succeeded
Details
electron-mas-testing Build #20190103.52 succeeded
Details
electron-osx-testing Build #20190103.52 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 3, 2019

Release Notes Persisted

Add a way to query for system colors on MacOS via systemPreferences.getSystemColor().

@codebytere codebytere deleted the add-system-color branch Jan 3, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

@oskarkrawczyk

This comment has been minimized.

Copy link

commented Feb 12, 2019

@codebytere Out of curiosity:

There will be a second follow-up PR that adds MacOS support for Dynamic Colors

I can't seem to find this anywhere, did you have a chance to work on it?

UPDATE: Nevermind, found it! Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.