New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add link to clerk readme to PR checklist #16253

Merged
merged 5 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@BinaryMuse
Copy link
Member

BinaryMuse commented Jan 3, 2019

Description of Change

A small refinement on #16080, this simply adds a clickable link to the checklist that leads to the Clerk readme, where we give examples and details of good release notes.

/cc @ckerr

Checklist

  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: no-notes

@BinaryMuse BinaryMuse requested a review from electron/electrocats as a code owner Jan 3, 2019

BinaryMuse added some commits Jan 3, 2019

@BinaryMuse BinaryMuse merged commit 5c378de into master Jan 3, 2019

4 of 10 checks passed

appveyor: win-ia32-debug Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 3, 2019

No Release Notes

@BinaryMuse BinaryMuse deleted the mkt-add-link-to-release-notes-guidelines branch Jan 3, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment