docs: Update reference to xcode 8.3.3 #16267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jan 4, 2019
|
Merging as arm failure is unrelated to doc change. |
|
Release Notes Persisted no-notes |
This was referenced Jan 4, 2019
|
I have automatically backported this PR to "3-0-x", please check out #16270 |
|
I have automatically backported this PR to "3-1-x", please check out #16271 |
|
I have automatically backported this PR to "4-0-x", please check out #16272 |
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
* Update reference to xcode * Update to reflect use of 10.12 SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR updates the mac build instructions to properly reflect which version of xcode is used for official Electron builds. Resolves #16244.
Checklist
Release Notes
Notes: no-notes