Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: update license year #16287
+1
−1
Conversation
keshaldesai
requested a review
from
as a
code owner
Jan 5, 2019
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Jan 5, 2019
|
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
BinaryMuse
approved these changes
Jan 5, 2019
BinaryMuse
merged commit 5957ede
into
electron:master
Jan 5, 2019
20 of 21 checks passed
ci/circleci: mas-testing-tests
Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request
ready to be squashed
Details
WIP
Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing
Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests
Your tests passed on CircleCI!
Details
ci/circleci: mas-testing
Your tests passed on CircleCI!
Details
ci/circleci: osx-testing
Your tests passed on CircleCI!
Details
ci/circleci: osx-testing-tests
Your tests passed on CircleCI!
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Jan 5, 2019
|
No Release Notes |
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Jan 5, 2019
|
Congrats on merging your first pull request! |
andrewkisliakov-citrix
added a commit
to andrewkisliakov-citrix/electron
that referenced
this pull request
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
keshaldesai commentedJan 5, 2019
•
edited by BinaryMuse
Description of Change
This PR is an update of the license to include the current year.
Checklist
npm testpassesRelease Notes
Notes: no-notes