New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable autofill popups on mac #16308

Merged
merged 9 commits into from Feb 11, 2019

Conversation

Projects
None yet
4 participants
@brenca
Copy link
Member

brenca commented Jan 7, 2019

Description of Change

Pretty much what the label says, it looks like shuffling some code around was enough to enable autofill popups on Mac. This PR also fixes the positioning (the popup appeared below the autofilled element before, now it matches chrome (if there is no space, it appears above the element)).

Resolves #360

Checklist

Release Notes

Notes: Enabled autofill popups on Mac.

@brenca brenca requested review from nornagon , zcbenz and codebytere Jan 7, 2019

@brenca brenca requested a review from electron/reviewers as a code owner Jan 7, 2019

@brenca brenca force-pushed the brenca/autofill-mac branch from d21bd3a to 4eabb8d Jan 8, 2019

@brenca brenca changed the title fix: enable autofill popups on Mac fix: enable autofill popups on mac Jan 8, 2019

@Argetan Argetan referenced this pull request Jan 20, 2019

Open

Login dropdown werkt niet #6

@brenca brenca force-pushed the brenca/autofill-mac branch from 56e95b6 to 92f069a Jan 29, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Feb 1, 2019

@brenca can you rebase this PR with the latest from master? That should resolve the failing CI.

@brenca brenca force-pushed the brenca/autofill-mac branch from f1145b3 to f00787b Feb 4, 2019

@nornagon
Copy link
Contributor

nornagon left a comment

I love those deleted lines :)

@nornagon
Copy link
Contributor

nornagon left a comment

Seems fine to me :)

@brenca brenca force-pushed the brenca/autofill-mac branch from ba02337 to 8685356 Feb 7, 2019

@brenca brenca added the target/5-0-x label Feb 7, 2019

@jkleinsc jkleinsc merged commit ccc60a1 into master Feb 11, 2019

9 checks passed

Absolute Zero
Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 11, 2019

Release Notes Persisted

Enabled autofill popups on Mac.

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Feb 11, 2019

I have automatically backported this PR to "5-0-x", please check out #16880

@trop trop bot added in-flight/5-0-x and removed target/5-0-x labels Feb 11, 2019

@jkleinsc jkleinsc deleted the brenca/autofill-mac branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment